Provide Visible Error if <py-env> paths is used in a local HTML file #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
fpliger
requested changes
May 11, 2022
There was a problem hiding this comment.
@JeffersGlass thanks, this is great! Left some comments that is worth checking/addressing but overall the PR intent lgtm. If you can address what's needed in the comments and check linting (that is causing CI to fail) I'd be happy to merge! 🚀
for more information, see https://pre-commit.ci
fpliger
approved these changes
May 18, 2022
There was a problem hiding this comment.
@JeffersGlass thanks for the contribution! Nice addition to gracefully fail in case of errors... I've made a couple of changes to merge main into the branch and to reuse the error handling elsewhere as well. TY!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a warning if a user tries to use Paths when opening an HTML file locally instead of using a webserver.
Specifically, if pyfetch() errors when trying to load a local file (given by paths), a warning will be logged to the console, explaining that a server is necessary to read from local files, and a warning (current a red <div> at the top of the <body> section) will be added to the screen. The console warning starts with 'PyScript' to draw users' (especially new users') attention there.
The method of showing the error is a new function showError() in utils.ts. The styling is very 1995 (see picture above) and should probably change as styling improves, but hopefully this provides a place to start.
Currently, the two errors from pyfetch (
Access to fetch at file:///...andGET file:\\\...are not suppressed, though it might be clearer if they were. My understanding is that since pyfetch is a thin wrapper around Fetch, hiding those errors in the console would mean monkey-patching pyfetch()? Or perhaps there's a cleverer way.Resolves #257, and hopefully clarifies other issues listed there.