Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add : japanese translation to doc #389

Closed
wants to merge 13 commits into from

Conversation

obutora
Copy link

@obutora obutora commented May 16, 2022

I'm excited to see such a great project!!

Pyscript has become a big topic in Japan, and many engineers want to use it.
I have added Japanese translations to README.md and GETTING-STARTED.md for Japanese-speaking people who want to take this opportunity to use PyScript.

I hope that the PyScript community will grow further.

Thank you for reading.

Copy link
Contributor

@verhulstm verhulstm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks. we might want more help from you as we make more docs :)

@obutora
Copy link
Author

obutora commented May 16, 2022

I would love to do it when that time comes. Thank you!

@fpliger
Copy link
Contributor

fpliger commented May 17, 2022

Thank you so much @obutora !! This is awesome!!

We are in the process of merging the documentation infrastructure and that will follow with a push on the docs. So things might change in the next few days. For this reason, I'll wait for a little to merge this just to avoid adding confusion.

Copy link
Contributor

@woxtu woxtu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I've added several suggestions so could you check them out?

doc_jp/GETTING-STARTED.md Outdated Show resolved Hide resolved
doc_jp/GETTING-STARTED.md Outdated Show resolved Hide resolved
doc_jp/GETTING-STARTED.md Outdated Show resolved Hide resolved
doc_jp/GETTING-STARTED.md Outdated Show resolved Hide resolved
doc_jp/GETTING-STARTED.md Outdated Show resolved Hide resolved
doc_jp/GETTING-STARTED.md Outdated Show resolved Hide resolved
doc_jp/GETTING-STARTED.md Outdated Show resolved Hide resolved
doc_jp/GETTING-STARTED.md Outdated Show resolved Hide resolved
obutora and others added 8 commits May 18, 2022 11:50
Co-authored-by: woxtu <woxtup@gmail.com>
Co-authored-by: woxtu <woxtup@gmail.com>
Co-authored-by: woxtu <woxtup@gmail.com>
Co-authored-by: woxtu <woxtup@gmail.com>
Co-authored-by: woxtu <woxtup@gmail.com>
Co-authored-by: woxtu <woxtup@gmail.com>
Co-authored-by: woxtu <woxtup@gmail.com>
Co-authored-by: woxtu <woxtup@gmail.com>
@obutora
Copy link
Author

obutora commented May 18, 2022

@woxtu Thank you for your good review!!
With your fix, the notation is less erratic and more consistent.

I use テキスト校正くん in this commit. This suggest that したがって is more readable than 従って.
but In this case, I thought your correction was correct because it means to obey, not as a conjunction.

Thank you for your polite review🙏 🤩

@fpliger fpliger added status: paused PR that has been put on hold tag: docs Related to the documentation waiting on feedback Issue or PR waiting on feedback from core team labels Jun 10, 2022
@tedpatrick
Copy link
Contributor

Thank you for your PR contribution to PyScript. We are closing PRs older than 90 days with limited activity.

@tedpatrick tedpatrick closed this Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: paused PR that has been put on hold tag: docs Related to the documentation waiting on feedback Issue or PR waiting on feedback from core team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants