Move example to root directory [To Merge with 433] #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this and #435 are probably duplicates... which one should we keep @marimeireles @pww217 ? |
|
@fpliger good point, didn't realize #433 also moved the actual examples. This one does have a few extra items though (READMEs, CI changes) so I'll manually merge them and close this. Also we still have the issue of it deleting certain files without moving them (as far as I can tell) but we can tackle that in @marimeireles's PR. |
pww217
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been discussed and from a readability and CI standpoint it makes more sense for examples to live at the root.
I've changed the examples themselves, the CI, and the READMEs but I'm not 100% sure on some of the other stuff, and I'll leave comments below.
I'm also not sure why some files that I moved seem to have been deleted instead, specifically some whl files and such. If anyone has an idea why that happened when I just dragged the folder, I'd love to know.
Lastly this breaks the pytest files and I'm not exactly sure how the examples dir is set in that.