Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for python 3.10 #35

Closed
HugoJBello opened this issue Sep 22, 2022 · 7 comments
Closed

Support for python 3.10 #35

HugoJBello opened this issue Sep 22, 2022 · 7 comments

Comments

@HugoJBello
Copy link
Contributor

Hi, first of all great work!

I am trying to install the dependency with pip in python3.10

when I run the command:

pip3 install git+https://github.com/pysentimiento/pysentimiento.git

I get the error:

ERROR: Package 'pysentimiento' requires a different Python: 3.10.4 not in '<3.10,>=3.7'

Have you thought in making the library compatible with python3.10?

Thanks in advance.

@finiteautomata
Copy link
Collaborator

Hi @HugoJBello, thanks for your kind comment 😄

This is related to #34. TBH, it is just a matter of changing the pyproject.toml file to allow the 3.10 version and check if the tests are running. I am a bit out of time right now, but if you can and want, you can try it and create a PR!

@HugoJBello
Copy link
Contributor Author

@finiteautomata I did as you suggested, I created a PR.

@finiteautomata
Copy link
Collaborator

finiteautomata commented Sep 29, 2022 via email

@celisa
Copy link

celisa commented Oct 15, 2022

Any updates on this issue?

@finiteautomata
Copy link
Collaborator

@celisa we've been trying to keep compatibility from python 3.7 to 3.10 in #36; however, I couldn't find any feasible way to do this.

I think that I will release pysentimiento 0.5.1 dropping dependency with 3.7, and keep maintaining 0.4.x for the next couple of months (until 3.7 definitely gets deprecated)

@finiteautomata
Copy link
Collaborator

@HugoJBello and @celisa: you can now try pysentimiento 0.5.2 which is 3.10-compatible.

Feel free to reopen if you find any issue. Thanks @HugoJBello for your help!

@HugoJBello
Copy link
Contributor Author

great work @finiteautomata !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants