Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_serial_connection() got multiple values for keyword argument 'loop'" #5

Closed
potens1 opened this issue Jul 2, 2016 · 2 comments

Comments

@potens1
Copy link
Contributor

potens1 commented Jul 2, 2016

if loop argument is already passed, it should be removed of kwargs, or if not passed, add it to kwargs and remove it from explicitly passing it
https://github.com/pyserial/pyserial-asyncio/blob/master/serial_asyncio/__init__.py#L398

@potens1
Copy link
Contributor Author

potens1 commented Jul 3, 2016

Not able to reproduce again, I'll close my self the issue since it should come from bad manipulation from my side

@potens1 potens1 closed this as completed Jul 3, 2016
@rob-smallshire
Copy link
Collaborator

Just as a note for anyone else arriving here, loop is using a new Python feature called 'keyword-only arguments'. It's an error to pass loop as a positional argument.

iiSeymour added a commit to iiSeymour/pyserial-asyncio that referenced this issue Jan 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants