Skip to content

Commit

Permalink
fix: port_publisher typo
Browse files Browse the repository at this point in the history 
fixes #228
  • Loading branch information
@zsquareplusc
zsquareplusc committed May 8, 2017
1 parent fc1bf5a commit 055f31c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion examples/port_publisher.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,7 @@ def close(self):
if pid > 0:
# exit from second parent, save eventual PID before
if args.pidfile is not None:
open(args.pidfile, 'w').write("{}".formt(pid))
open(args.pidfile, 'w').write("{}".format(pid))
sys.exit(0)
except OSError as e:
log.critical("fork #2 failed: {} ({})\n".format(e.errno, e.strerror))
Expand Down

3 comments on commit 055f31c

@philb32
Copy link

@philb32 philb32 commented on 055f31c May 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well yes, looks good, but not sure how to +2 it or "ship it" or whatever is required, so will leave it to somebody else.

@philb32
Copy link

@philb32 philb32 commented on 055f31c May 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem with python that this is a runtime error ... blah ... etc.

@jj100
Copy link

@jj100 jj100 commented on 055f31c Aug 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All modules are incomplete or generate many communications problems (serial port, bluetotth) , for example

portnames = scanSerial()
Traceback (most recent call last):
File "<pyshell#0>", line 1, in
portnames = scanSerial()
NameError: name 'scanSerial' is not defined

from .protocols import *
Traceback (most recent call last):
File "<pyshell#1>", line 1, in
from .protocols import *
ModuleNotFoundError: No module named 'main.protocols'; 'main' is not a package
from .utils import OBDStatus
Traceback (most recent call last):
File "<pyshell#2>", line 1, in
from .utils import OBDStatus
ModuleNotFoundError: No module named 'main.utils'; 'main' is not a package

Please sign in to comment.