Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting a custom baudrate on the MIPS platform #496

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

ckielstra
Copy link
Contributor

Fixed the issue where a custom baudrate could not be set for the MIPS platform.
The hard coded values in the IOCTL call do differ in MIPS when compared to most other platforms.

This problem manifested itself on the OpenWRT platform where most of the smaller router devices are using a MIPS processor. Trying to open a port with a speed of 250k baud would result in the error message "not a tty". This is fixed now with this pull request.

@ihrapsa
Copy link

ihrapsa commented Feb 22, 2021

Is this going to be merged afterall?

Fixed the issue where a custom baudrate could not be set for the MIPS platform.
The hard coded values in the IOCTL call do differ in MIPS when compared to most other platforms.
@ckielstra
Copy link
Contributor Author

Updated the pull-request in order to clear the unrelated CI-error caused by python 3.1 and 3.2 not working (and now being dropped).
I don't know who determines if and when a pull-request will be accepted.

@ihrapsa
Copy link

ihrapsa commented Jun 8, 2021

hi, any progress on merging this?

@zsquareplusc
Copy link
Member

would have been easier/faster if a note was provided on how to get/verify these values... i don't want to break it for others so i wanted to know if this is generic for mips or specific for the kernel on your device..

my research leads to _IOC_READ/_IOC_WRITE being defined differently for the mips platform in the kernel.

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/mips/include/uapi/asm/ioctl.h?h=v5.15-rc3
vs
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/uapi/asm-generic/ioctl.h?h=v5.15-rc3

thank you

@zsquareplusc zsquareplusc merged commit baa7c78 into pyserial:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants