workaround win32 crash (or error) on SetCommState #669
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe there is a bug (a.k.a the crash "OSError: exception: stack overflow") in
SetCommState
.Steps to trigger the crash
SetupComm
,XonLim
andXoffLim
to (102400 / 4) inSetCommState
mode
command to reconfigure it.Test Environment
Expected Behavior
Window may return an error code but not crash if it finds something strange.
Workaround
It seems unrealistic to wait MS to fix this. So here comes the workaround, which might also resolve #258 and #362:
Set
XonLim
andXoffLim
according to buffer size configured inSetupComm
.