Makes serialposix.Serial.write() respect non-blocking #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rob-smallshire
force-pushed
the
non_blocking_write
branch
from
0b7ac15
to
325a738
Compare
|
Thank you for all these nicely formatted pull requests. |
|
@zsquareplusc You're welcome. I have some more asyncio changes in the works to complete the details in the transport to provide async buffered writing. |
mr-loading
pushed a commit
to mr-loading/pyserial
that referenced
this pull request
Mar 12, 2024
* Updated dependencies and go version to 1.18 * Updated go to v1.18 in github workflow files * Upgraded spf13/cobra to v1.5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pySerial documentation states that a write_timeout setting of zero should result in non-blocking write() behaviour. This pull-request modifies serialposix.Serial.write() to respect that requirement, by distinguishing between zero and non-zero numeric timeouts. In the zero timeout case, the underlying write() call is made and then the function immediately returns the number of bytes written, which may not be all of the data which which was passed to write.
The previous version of the code would iterate, using select(), until all data had been written, effectively blocking from the clients point of view. True non-blocking writes are essential for a high-quality asyncio serial implementation.