Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prior and Rendering changes #42

Merged
merged 8 commits into from
Oct 6, 2023
Merged

Prior and Rendering changes #42

merged 8 commits into from
Oct 6, 2023

Conversation

tbmiller-astro
Copy link
Collaborator

These are some backend changes to the priors and renderering modules mostly. Nothing user facing but changes to make upkeep a little easier and help with the planned addition of multi-band fitting. The main changes are as follows

  • Rendering

    • Parameters now passed around in dictionaries rather than as arguments to the function
    • All render_{type} functions now return 3 arrays, the Fourier transform, the intrinsic image and the convolved image. If the method currently being used doesn't use one of these it results in zeros. The BaseRenderer class now has a method called combine_scene which takes these three inputs to produce the final model image. This should make it easier to add extra renderers and types of source.
    • For rendering multiple sources now takes a dictionary of all the source parameters rather than being seperated
  • Priors

    • Commensurate with above the sampling now the sampling functions return the parameters in a dictionary
    • Sky sampling now move to separate classes
    • Better tools for dealing with suffixes for SourcePrior and MultiPrior
  • misc.

    • added suffix arguments to all of the loss functions
    • added ability to reparam model for sampling
    • Changes to the test suites to work with all of the changes

@prappleizer prappleizer merged commit cf42d64 into main Oct 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants