Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial multiband implementation #45

Merged
merged 14 commits into from
Jan 29, 2024
Merged

Initial multiband implementation #45

merged 14 commits into from
Jan 29, 2024

Conversation

tbmiller-astro
Copy link
Collaborator

@tbmiller-astro tbmiller-astro commented Nov 7, 2023

Initial implementation of joint modeling across multiple bands

The FitMultiBand[X] classes take a list of FitSingle or FitMulti classes as input along with an array of the wavelengths at each band. The parameters specified by linked_params are jointly fit across all bands while all others are fit independently. There are currently two implementations: The first, following previous implementations, "linking" these parameters using polynomials and the other using B-Splines. These implementations are basic but should be fully functional.

Things to-do before merge-able

  • Finalize UI and how the classes are initialized
  • Finalize interface with results class
  • Finalize documentation and add tutorial
  • Add tests
  • Currently necessitates pixel scale and zero points are the same across all images, but should be simple enough to add the ability to vary this (just a multiplicative factor)
  • Maybe more?

@tbmiller-astro
Copy link
Collaborator Author

Okay I am pretty happy with where this is now.

The only major thing we could add is difference in pixel scale and flux scaling. I don't have a huge need for this now but it could be useful for some.

@tbmiller-astro tbmiller-astro merged commit d228099 into main Jan 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant