Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Level-1 pre-processor does not properly merge l1 segments #91

Closed
1 task done
shendric opened this issue Aug 11, 2022 · 4 comments
Closed
1 task done

Level-1 pre-processor does not properly merge l1 segments #91

shendric opened this issue Aug 11, 2022 · 4 comments
Assignees
Labels
bug Something isn't working data input data sets

Comments

@shendric
Copy link
Collaborator

shendric commented Aug 11, 2022

Expected behaviour of the Level-1 pre-processor is to merge trajectory data from different input files, if these are connected.

An evalution of CryoSat-2 l1p (cryosat2_pds_ipf1e_v1p1) has revealed that this is not always the case and data gaps arise in areas with a frequent land segments:

pysiral-l1p-bug

The figure shows the (lon, lat) location of all data points in the time_orbit data group for l1p files within a given day. Colors indicate extent of l1p files.

Actions

  • Identify and correct issue in l1 pre-processor
@shendric shendric self-assigned this Aug 11, 2022
@shendric shendric added bug Something isn't working data input data sets AWI CryoSat-2 labels Aug 11, 2022
@shendric
Copy link
Collaborator Author

shendric commented Aug 11, 2022

Improved with 957228a, but issues still remain. E.g. in the updated plot the trajectory after 31 (was 48 in previous plot) is missing:

cs2-tds-l1p-20211012-orbits

Also 13 should be connected to 14

@shendric
Copy link
Collaborator Author

A fix has been found for the missing orbit segment (0ec0073), but there are still some segments that do not connect properly (Example 17, 18, 19 in the figure below)

cs2-tds-l1p-20211012-orbits

@shendric
Copy link
Collaborator Author

An additional CryoSat-2 related bug was corrected that led to mixup of TAI and UTC timestamps when checking if l1 polar ocean segments should be merged (74a23c7). The test output is now nominal.

cs2-tds-l1p-20211012-orbits

@shendric
Copy link
Collaborator Author

The remaining issue is an inconsistency in the handling of land segments: A land segment of a give length might be included if it occurs within a single source file, but the l1p output might be split into two files if the land segment would occur at the edge of two source files.

In the example above, segments 13 and 14 are split at Nowaja Semlja, while segment 33 (number shown only in previous comment) cut right accros it:

grafik

The reason for this behaviour is that the treshold for connecting l1p segments is set to 10 seconds ( max_connected_segment_timedelta_seconds), while the Level-1 pre-processor allows to include 1000 waveforms (= 50 seconds at 20Hz) of land within one segment:

code

It should be investigated if max_connected_segment_timedelta_seconds should be changend.

@shendric shendric removed this from the CryoTEMPO Cycle 2.1 TDS milestone Feb 10, 2023
@shendric shendric added this to the CryoTEMPO Phase 2.1 milestone Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data input data sets
Projects
None yet
Development

No branches or pull requests

1 participant