Exception inherit from Exception

Exception should inherit from builtin Exception not BaseException
pyslackers · Dec 17, 2017 · ae912e7 · ae912e7
1 parent 66f128b
commit ae912e7
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/slack/exceptions.py b/slack/exceptions.py
@@ -1,7 +1,7 @@
 import http
 
 
-class HTTPException(BaseException):
+class HTTPException(Exception):
     """
     Raised on non 200 status code
 
@@ -20,7 +20,7 @@ def __str__(self):
         return '{}, {}'.format(self.status.value, self.status.phrase)
 
 
-class SlackAPIError(BaseException):
+class SlackAPIError(Exception):
     """
     Raised for errors return by the Slack API
 
@@ -54,7 +54,7 @@ def __str__(self):
         return HTTPException.__str__(self) + ', retry in {}s'.format(self.retry_after)
 
 
-class FailedVerification(BaseException):
+class FailedVerification(Exception):
     """
     Raised when incoming data from Slack webhooks fail verification