Fixed typing error in msat back #470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recently added theory combination example raised a typing error within the back function of the msat converter. The error was due to INT/REAL distinction made by pysmt that is ignored by mathsat for numeric constants. The fix consists in asking the type system of mathsat the relevant types instead of determining them using the pysmt type-checker. NOTE: this bug was highlighted by the new "theory combination" example added in #451 but the PR was accepted beacuse Travis is currently broken. We need to finish with #469 to trust CI again.
mikand
added a commit
that referenced
this pull request
Jan 16, 2018
This merges #470 to get test passed
|
This PR has been merged in #469 to have a single PR taht fixes the issues on master |
nbailluet
pushed a commit
to nbailluet/pysmt
that referenced
this pull request
Mar 14, 2024
This merges pysmt#470 to get test passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently added theory combination example raised a typing error within the back function of the msat converter. The error was due to INT/REAL distinction made by pysmt that is ignored by mathsat for numeric constants. The fix consists in asking the type system of mathsat the relevant types instead of determining them using the pysmt type-checker.
NOTE: this bug was highlighted by the new "theory combination" example added in #451 but the PR was accepted beacuse Travis is currently broken. We need to finish with #469 to trust CI again.