[msat-installer] Don't use $ORIGIN on darwin

[leonardt]

Before this commit, I get the following message:

$ pysmt-install --msat
...
ld: warning: directory not found for option '-L$ORIGIN'

From my brief perusing of the internet, it seems that $ORIGIN is a linux specific construct.

[mikand]

Hi! Thanks for the fix! Since we do not have an Apple machine this slipped in... 😄

[randomir]

I don't have a Mac to test it right now, but I'm not sure this patch helps in building msat as run-path dependent library.

We have to check how to use distutils' support for RPATH via -R option to setup.py on MacOS, to build run-path dep libs.

Or maybe library lookup works as is (with this patch applied), but that should also be verified.

[marcogario]

I think this PR was about removing a piece of information that is not needed. Whether msat is being build as a run-path dependent library or not is independent from this.

If you think this might be an issue, please open an issue. You can also describe how we could test this on Travis, that would be the easiest way. I am not sure whether you meant to reply to the PR or to the issue #519 .

We are using the setup.py from upstream. If there is an issue there, we need to file a bug-report with the MathSat team.

[randomir]

Excuse me, @marcogario, if I misunderstood something here. My impression was msat won't work either way (because it won't find the library in ./, since rpath-equivalent is not specified), and that this PR only removes a compiler warning. As I said, I don't have a Mac to test that, so my assumption/understanding might be completely wrong. Just wanted to chip in my 2c.

Now that I think about it, since Travis tests on Mac are passing, seems msat without rpath does indeed work. So, sorry for causing confusion.