Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several HighLevelElements (Sinusoidal, AmplitudeModulated...) should also implement currentSource #20

Closed
rafadose opened this issue Mar 7, 2016 · 1 comment
Closed

Several HighLevelElements (Sinusoidal, AmplitudeModulated...) should also implement currentSource #20

rafadose opened this issue Mar 7, 2016 · 1 comment
Labels
unimplemented WISH
Milestone
V1.2

Comments

@rafadose
Copy link

rafadose commented Mar 7, 2016

Several high level elements (like sinusoidal, amplitudeModulated, exponential...) are implemented as voltage only when they can also be current sources.
I suggest to implement a generic Source in BasicElement with the attribute type to select between voltage and current and use this Source in all HighLevelElements.

Apologies, this is a known issue; I have just noticed the Fixme comment in HighLevelElement.py:
# Fixme: these waveforms can be current sources as well

Regards
@FabriceSalvaire FabriceSalvaire modified the milestones: V2, V1.2 Sep 17, 2017
@FabriceSalvaire
Copy link
Collaborator

fixed in 47d7f99

@FabriceSalvaire FabriceSalvaire mentioned this issue Sep 25, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
unimplemented WISH
Projects
None yet
Milestone
V1.2
Development

No branches or pull requests
2 participants
@rafadose @FabriceSalvaire