Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: curl in gitbash doesn't support --cipher #1244

Merged
merged 2 commits into from Dec 13, 2023
Merged

fix: curl in gitbash doesn't support --cipher #1244

merged 2 commits into from Dec 13, 2023

Conversation

Derisis13
Copy link
Collaborator

@Derisis13 Derisis13 commented Dec 12, 2023 •
edited

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

Fix for the common windows issue "no results found"

Checklist

  • any anime playing
  • bumped version
  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e select episode works
  • -S select index works
  • -r range selection works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)
  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

@port19x port19x merged commit 129244a into master Dec 13, 2023
10 checks passed
@port19x port19x deleted the curlfix branch December 13, 2023 08:32
PhosCity pushed a commit to PhosCity/ani-cli that referenced this pull request Dec 13, 2023
@Derisis13 @PhosCity
fix: curl in gitbash doesn't support --cipher (pystardust#1244)
116f33d
@Derisis13 Derisis13 mentioned this pull request Dec 20, 2023
Closed
@71zenith 71zenith mentioned this pull request Jan 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justchokingaround justchokingaround justchokingaround approved these changes

@port19x port19x port19x approved these changes

@CoolnsX CoolnsX Awaiting requested review from CoolnsX

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Derisis13 @justchokingaround @port19x