Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: script speed improvement on windows #1262

Merged
merged 2 commits into from Jan 22, 2024
Merged

feat: script speed improvement on windows #1262

merged 2 commits into from Jan 22, 2024

Conversation

CoolnsX
Copy link
Collaborator

@CoolnsX CoolnsX commented Jan 22, 2024

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

This PR fixes the slowness of script on windows during episode fetching, where the user waits upto ~30 seconds for it to fetch.
I have tested it on linux and with the help of some plebs, also on windows. Please test it thoroughtly on both platforms and also on other platform to maintain compatibility

Checklist

  • any anime playing
  • bumped version

  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e select episode works
  • -S select index works
  • -r range selection works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)

  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

@CoolnsX
Copy link
Collaborator Author

CoolnsX commented Jan 22, 2024

Benchmarks

Implementation in master branch script --
image

Implemetation in this PR --
image2

@justchokingaround
Copy link
Collaborator

unsolicited yoinking of my media 🙄

@port19x port19x merged commit d4ecd68 into master Jan 22, 2024
8 checks passed
@port19x port19x deleted the windows_fix branch January 22, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants