fix: making this work on OpenBS with non-GNU tools #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced `\t` and `\n` with actual tab and newline characters in `sed` commands, as well as `\s` with `[[:space]]` in `grep`, so that it works on non-GNU systems. Should be tested on other OSes though
Closed
Closed
xezo360hye
changed the title
Idk I just set it to the next after mine. Not sure if it's supposed to be done this way but ok
port19x
approved these changes
Mar 1, 2024
|
Thank you for the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Type of change
Description
Small syntax changes required to make this work on OpenBSD (and potentially other non-GNU/*BSD systems). Involved replacing
\nand similar backslash-escaped characters with their literal representations (actual newline, tab). Should not break anything on other systems, checked briefly on NixOS, runs fineChecklist
-chistory and continue work-ddownloads work-ssyncplay works-qquality works-vvlc works-eselect episode works-Sselect index works-rrange selection works--skipani-skip works--skip-titleani-skip title argument works--no-detachno detach works--duband regular (sub) mode both work-hhelp info is up to dateAdditional Testcases