feat: use invidious api to get healthy instances #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Euro20179
requested changes
Sep 8, 2022
Euro20179
reviewed
Sep 8, 2022
- The instance selection and caching code is now in the Post opt scrape section. The logic for this change is as follows: "_If the user sets `instances_file` or `cache_dir` in their config, the file will be in the wrong place because the config is read after creating the file._" - Additionally, code now sets `invidious_instance` only if it isn't already set.
Euro20179
reviewed
Sep 9, 2022
Code now fails, with proper error messages, if cURL encounters errors while fetching `instance_list`. This is necessary so that the code doesn't simply write out an empty `instance_list`. In the worst case scenario, it could even replace a previously usable `instance_list` with an empty one! Additionally, a nice status message informs the user what is going on.
Euro20179
reviewed
Sep 9, 2022
|
Nice work! |
|
Thank you for all the help as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #570.
Quick and dirty implementation of the process explained in the issue above.
I am not well versed with
jq, so this might be a roundabout manner of doing what needs to be done!TODO: need to implement logic for staleness of the cached instance list.