fix: fzf ignores FZF_DEFAULT_OPTS if not exported #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workaround introduced in 468d5d9 for setting the right-side margins for `fzf` via prepending to `FZF_DEFAULT_OPTS` only gets propagated to subsequent invocations of `fzf` if the `FZF_DEFAULT_OPTS` is exported by the caller in the first place. (Re-)exporting the variable works in both situations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workaround introduced in 468d5d9 for setting the right-side margins for
fzfvia prepending toFZF_DEFAULT_OPTSonly gets propagated to subsequent invocations offzfif theFZF_DEFAULT_OPTSis exported by the caller in the first place. (Re-)exporting the variable works in both situations.