Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emit deprecation warnings for custom logging functions #442

Merged
merged 1 commit into from Oct 28, 2020

Conversation

pmeier
Copy link
Member

@pmeier pmeier commented Oct 28, 2020

This foreshadows #434

@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #442 into master will decrease coverage by 0.0%.
The diff coverage is 88.2%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #442     +/-   ##
========================================
- Coverage    90.7%   90.7%   -0.1%     
========================================
  Files          63      63             
  Lines        3091    3106     +15     
========================================
+ Hits         2806    2819     +13     
- Misses        285     287      +2     
Impacted Files Coverage Δ
pystiche/optim/optim.py 96.3% <80.0%> (-1.1%) ⬇️
pystiche/misc.py 95.9% <100.0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd34c10...7f32b8a. Read the comment docs.

@pmeier
Copy link
Member Author

pmeier commented Oct 28, 2020

Lint error is unrelated and was fixed in #443.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant