Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README for building using Vagrant and Ansible #1147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add README for building using Vagrant and Ansible #1147

wants to merge 1 commit into from

Conversation

KrishMunot
Copy link
Contributor

No description provided.

@kmod
Copy link
Collaborator

kmod commented May 6, 2016

This looks great, but do we have a vagrant file?

@KrishMunot
Copy link
Contributor Author

Yes, we do have a vagrant file
I hope this can get merged. 😃

@kmod
Copy link
Collaborator

kmod commented May 6, 2016

Oh, ok didn't realize that this was on top of the other PR. It might be nice to rebase your commit on top of that other PR and then submit them together as the PR, since we would want to merge them at the same time (not one without the other).

Your doc mentions the tools/vagrant directory, which doesn't look like it exists. Does that get created somehow?

@KrishMunot
Copy link
Contributor Author

Yes, that makes sense. :)

Yea, the directory gets created automatically that way.

@aisk
Copy link
Contributor

aisk commented May 20, 2016

Hi @KrishMunot , I saw your PR is using vagrant and ansible, but #1104 dosen't using ansible, and the Vagrantfile is in the project's root folder (I think it's common usage for most projuect).

@kmod kmod mentioned this pull request Jun 8, 2016
@kmod kmod force-pushed the master branch 2 times, most recently from 352fd89 to 6488a3e Compare October 28, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants