Switch from storing settings in config.json to storm.yaml #274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't quite ready for primetime yet, but I wanted to create the PR as a discussion point.
What currently works is that if we find you have a config.json file, we'll automatically load it and then dump the settings in there into a
streamparse
dict withinstorm.yaml
.get_config
and everything downstream of it has been adapted to handle this extra level of nesting in the dict thatget_config
returns.What I have not done yet, but would like to do, is switching our environment-specific settings to match the general
storm.yaml
setting names (i.e.,nimbus.host
ornimbus.seeds
instead of justnimbus
, andtopology.workers
instead ofworkers
), and then falling back on thestorm.yaml
settings if you haven't setup an environment at all. This would allow people to reuse what they may already have instead of potentially putting the settings in two places in two different formats.Since we'll start parsing
storm.yaml
with this PR, I'm sure there are some other settings that we could probably pull out of it that we don't currently use that might be useful.