Switch to using parallel-ssh instead of fabric redux #411
Conversation
|
It appears the ssh2-python is currently incompatible with PyPy, so I'm going to hold off on this until ParallelSSH/ssh2-python#16 gets addressed. |
|
ssh2-python has fixed the issue on their end, but still waiting for a new parallel-ssh release with the fix there. |
dan-blanchard
force-pushed
the
tanaysoni-parallel-ssh
branch
from
b8e9f25
to
ba677e2
Compare
|
This needs more testing before merging. I've found a few cases where it seems like options aren't being resolved or sent to Storm properly. |
|
@dan-blanchard I'd be happy to have a look. Any pointers to reproduce the cases would be helpful. |
dan-blanchard
force-pushed
the
tanaysoni-parallel-ssh
branch
4 times, most recently
from
2c15241
to
01d6e76
Compare
|
This is very close to being ready to merge. I am currently being foiled by ParallelSSH/ssh2-python#51 though. |
dan-blanchard
force-pushed
the
tanaysoni-parallel-ssh
branch
from
01d6e76
to
8e89cc2
Compare
dan-blanchard
force-pushed
the
tanaysoni-parallel-ssh
branch
from
62486f8
to
03cc96b
Compare
refactored _create_or_update_virtualenv to use parallel-ssh instead of fabric use pssh native client to avoid gevent monkey patch added parallel-ssh dependency replaced Fabric env with an analogous dict use parallel-ssh to tail logs removed Fabric constructs use parallel-ssh for 'remove_logs' use next as function for python3 compatability replace fabric with subprocess for local topology run shadown FileNotFoundError with IOError for python2 compatibility use fabric with subprocess for creating topology jar replace usage of fabric.colors with util functions removed fabric dependency Make sure we get output from update_virtualenv Placeholder
Fix libssh line in .travis.yml Use parallel-ssh version that is compatible with PyPy More parallel-ssh fixes Try newer PyPy
dan-blanchard
force-pushed
the
tanaysoni-parallel-ssh
branch
from
03cc96b
to
d2d5ed6
Compare
|
I've tested this with submitting topologies and running them locally, and it all seems to work now. |
dan-blanchard
force-pushed
the
tanaysoni-parallel-ssh
branch
from
d2d5ed6
to
d64676a
Compare
|
Ugh, the ssh2-python devs removed the wheels from PyPI (breaking the cardinal rule of never removing packages from PyPI). The pypy build will continue to fail until they put the latest version back. 😭 |
|
Seems like there's still an issue with getting all of the options resolved properly with this branch. A |
This has all of the commits from #400 plus some more to fix travis and fix some minor issues. I wanted to make changes before I merged it into master, and I wanted to be able to more easily test things on my machine.