NRTesting failing

[lrntct]

I followed the indications from the test README and ran into the following error:

$ nrtest execute apps/swmm-5111_x64.json tests/examples/Example1.inp
Traceback (most recent call last):
  File "/home/laurent/software/swmm_nrttest/bin/nrtest", line 106, in <module>
    args.func(args)
  File "/home/laurent/software/swmm_nrttest/bin/nrtest", line 29, in execute
    ts = TestSuite.read_config(args.app, test_files, args.output)
  File "/home/laurent/software/swmm_nrttest/local/lib/python2.7/site-packages/nrtest/testsuite.py", line 46, in read_config
    t = Test.for_execution(json.load(f))
  File "/usr/lib/python2.7/json/__init__.py", line 291, in load
    **kw)
  File "/usr/lib/python2.7/json/__init__.py", line 339, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python2.7/json/decoder.py", line 364, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python2.7/json/decoder.py", line 382, in raw_decode
    raise ValueError("No JSON object could be decoded")
ValueError: No JSON object could be decoded

Other combinations of json/inp give the same error.
OS: Ubuntu 17.10
swmm version 56fd8b2

Any idea?

[michaeltryby]

@lrntct you need to pass the json file describing the test to nrtest not the inp file. Like so
$ nrtest execute apps/swmm-5111_x64.json test/examples/example1.json
Also, you need to have the .exe file described in swmm-5111_x64.json on your path.

More information on nrtest can be found here.

[goanpeca]

@michaeltryby assuming someone has a clean install os Windows/Linux with nothing on it, what would be the steps to run the test suite. Any chance we could have those steps clearly described so we can post this inside the README of SWMM?

[michaeltryby]

The readme is located here. It needs to be updated. I will update it and then close this issue.

[lrntct]

@michaeltryby My bad, I read the readme too fast.
However, the test is still failing:

$ nrtest execute apps/swmm-5111_x64.json tests/examples/example1.json 
ERROR: Unable to find executable: "C:/Users/mtryby/bin/swmm5111_x64.exe"

[goanpeca]

Well the thing is that nrtest only runs against windows executables? so on linux or OSX we can't run nrtest in the current setup?

So we could maybe save the binary outputs ran on windows in another repository and use those as input for nrtest ?

[bemcdonnell]

Platform agnostic. Michael currently has this implemented in Travis on SWMM and EPANET.

[goanpeca]

Ok, then we really need to update those instructions

[bemcdonnell]

@michaeltryby, I’m really excited about your nrtest contributions to this project! :-)

[goanpeca]

@michaeltryby lets close after merge :-)

[goanpeca]

This is still an issue. See #121

[michaeltryby]

Nrtest is documented, there are SWMM instructions, there is a working example of it running under Travis CI.