-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small AppveyorCI and CMAKE Fixes #128
Conversation
bemcdonnell
commented
Dec 13, 2017
- Trying to make the lights green (at least on Appveyor).
Some of the settings pulled from a fresh downloaded compiler from EPA's website related to the default Release Configuration... (Looks like it does use fast floating point model...). VC2010-CLE
VC2010-DLL
|
3458b3a
to
fd4d96a
Compare
#set(EXECUTABLE_OUTPUT_PATH ${CMAKE_CURRENT_SOURCE_DIR}/bin) | ||
#set(LIBRARY_OUTPUT_PATH ${CMAKE_CURRENT_SOURCE_DIR}/lib) | ||
set(EXECUTABLE_OUTPUT_PATH ${CMAKE_BINARY_DIR}/bin) | ||
set(LIBRARY_OUTPUT_PATH ${CMAKE_BINARY_DIR}/lib) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change fixed Travis (For @michaeltryby).
@goanpeca, I've turned off most of the build matrix. We're in the green for the Benchmark compiler!!! (There are issues with finding OpenMP). VS2010, (if I understand this correctly), only allowed paid subscribers to use openMP for VS2010. |
@@ -15,26 +15,26 @@ environment: | |||
# VS_VERSION: "9 2008" | |||
# ARCH: Win64 | |||
# Python 3.4 | |||
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015 | |||
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2013 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this image change @bemcdonnell ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@goanpeca, I suppose we don't have to.. I was experiementing with trying to get OpenMP to work on VS2010
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well.. it does not matter much, just wondering why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want me to revert that change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naahh
Use of wrong variable for iteration: Addresses #128