Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding hypergraph/cell complex networks models/unit tests #182

Merged
merged 32 commits into from
Sep 8, 2023

Conversation

mhajij
Copy link
Member

@mhajij mhajij commented Sep 6, 2023

challenge CC networks unit tests.
challenge HG networks unit tests

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 98.82% and project coverage change: +0.15% 🎉

Comparison is base (5a32452) 97.71% compared to head (60fa425) 97.87%.
Report is 7 commits behind head on main.

❗ Current head 60fa425 differs from pull request most recent head 05ccc21. Consider uploading reports for the commit 05ccc21 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
+ Coverage   97.71%   97.87%   +0.15%     
==========================================
  Files          43       49       +6     
  Lines        1796     1790       -6     
==========================================
- Hits         1755     1752       -3     
+ Misses         41       38       -3     
Files Changed Coverage Δ
topomodelx/nn/cell/can.py 89.28% <89.28%> (ø)
topomodelx/nn/cell/ccxn.py 100.00% <100.00%> (ø)
topomodelx/nn/cell/cwn.py 100.00% <100.00%> (ø)
topomodelx/nn/hypergraph/allset.py 100.00% <100.00%> (ø)
topomodelx/nn/hypergraph/allset_transformer.py 100.00% <100.00%> (ø)
topomodelx/nn/hypergraph/dhgcn.py 100.00% <100.00%> (ø)
topomodelx/nn/hypergraph/hmpnn.py 100.00% <100.00%> (ø)
topomodelx/nn/hypergraph/hnhn.py 100.00% <100.00%> (ø)
topomodelx/nn/hypergraph/hypergat.py 100.00% <100.00%> (ø)
topomodelx/nn/hypergraph/hypersage.py 100.00% <100.00%> (ø)
... and 4 more

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mhajij mhajij changed the title cwn unit testing cell complex networks models and unit testing Sep 6, 2023
@mhajij mhajij changed the title cell complex networks models and unit testing adding hypergraph/cell complex networks models/unit tests Sep 7, 2023
Copy link
Collaborator

@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! THere are some typos and misnamings, see my comments

from topomodelx.nn.cell.can_layer import CANLayer, MultiHeadLiftLayer, PoolLayer


class CAN(torch.nn.Module):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhajij this one should be called CANBis: the name of the python class always matches the name of the file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was is supposed to be deleted because it is not faithful to the original implementation and we have a better one in the repo. I am deleting it in the next push.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

class TestCCXN:
"""Test CWN."""

def test_fowared(self):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

class TestCWN:
"""Test CWN."""

def test_fowared(self):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add the References section, in the docstrings, that cites the corresponding paper. You can copy paste the References section from the corresponding *_layer.py file.

Thanks @mhajij !

@mhajij
Copy link
Member Author

mhajij commented Sep 8, 2023

Could you also add the References section, in the docstrings, that cites the corresponding paper. You can copy paste the References section from the corresponding *_layer.py file.

Thanks @mhajij !

done

Copy link
Collaborator

@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be some commits missing: some typos have not been resolved.

Could you fix the Github conflicts before pushing to the PR? Thanks

class TestCAN:
"""Test CAN."""

def test_fowared(self):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed across all files.

from topomodelx.nn.cell.can_layer import CANLayer, MultiHeadLiftLayer, PoolLayer


class CAN(torch.nn.Module):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

@ninamiolane ninamiolane merged commit dc11ac4 into main Sep 8, 2023
3 of 4 checks passed
@ninamiolane ninamiolane deleted the migrate-ccns branch September 8, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants