Scone unified #188
Merged
Scone unified #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
==========================================
- Coverage 97.39% 97.35% -0.04%
==========================================
Files 35 34 -1
Lines 1535 1514 -21
==========================================
- Hits 1495 1474 -21
Misses 40 40 ☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
ffl096
force-pushed
the
scone_unified
branch
2 times, most recently
from
076463b
to
c29de9a
Compare
ffl096
approved these changes
Sep 8, 2023
ffl096
added
refactoring
simplicial
ffl096
force-pushed
the
scone_unified
branch
from
c29de9a
to
abb6133
Compare
|
I cleaned up the commit history without any content changes. Failed tests were unrelated (too many download requests for a dataset) but should pass now as well. As I am the last pusher, I cannot merge this pull request. |
mhajij
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both appear to implement the same... I think one can simply go; the standard scone appears better documented..