Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix weight parameter throughout source code #242

Merged
merged 1 commit into from Sep 14, 2023
Merged

Conversation

ffl096
Copy link
Member

@ffl096 ffl096 commented Sep 14, 2023

Even though weights are largely not implemented yet, many functions already have a weight parameter. This pull request fixes this weight parameter throughout the code base to be consistent and to make mypy happy (ref. #163).

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.13% ⚠️

Comparison is base (da155df) 85.89% compared to head (26ddc2c) 85.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
- Coverage   85.89%   85.76%   -0.13%     
==========================================
  Files          23       23              
  Lines        2828     2831       +3     
==========================================
- Hits         2429     2428       -1     
- Misses        399      403       +4     
Files Changed Coverage Δ
toponetx/algorithms/spectrum.py 100.00% <ø> (ø)
toponetx/classes/colored_hypergraph.py 72.08% <ø> (ø)
toponetx/classes/simplicial_complex.py 98.59% <50.00%> (-0.47%) ⬇️
toponetx/classes/cell_complex.py 87.74% <77.77%> (-0.26%) ⬇️
toponetx/classes/complex.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mhajij mhajij merged commit 2acd5c9 into main Sep 14, 2023
4 of 6 checks passed
@mhajij mhajij mentioned this pull request Sep 14, 2023
@ffl096 ffl096 deleted the frantzen-weight-parameter branch September 14, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants