Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup inner project #28

Merged
merged 17 commits into from
Nov 20, 2022
Merged

Cleanup inner project #28

merged 17 commits into from
Nov 20, 2022

Conversation

timmens
Copy link
Contributor

@timmens timmens commented Nov 19, 2022

Changes

All file names reference files from the inner project ({{cookiecutter.project_slug}}).

  • Make mdformat ignore README
  • Fix badges in README
  • Update tox.ini
  • Use the user-provided Python Version in environment.yml
  • Add pytask.ini_options to pyproject.toml

Todo

  • Reference issues which can be closed due to this PR with "Closes #x".
  • Review whether the documentation needs to be updated.
  • Document PR in docs/changes.rst.

Note

These are all very tiny changes, but when I used the cookiecutter-pytask-project I would always start by performing these. Therefore I think it could make sense to add them to the code base.

pre-commit-ci bot and others added 4 commits November 14, 2022 19:43
updates:
- [github.com/asottile/pyupgrade: v2.37.1 → v3.2.2](asottile/pyupgrade@v2.37.1...v3.2.2)
- [github.com/asottile/reorder_python_imports: v3.8.1 → v3.9.0](asottile/reorder-python-imports@v3.8.1...v3.9.0)
- [github.com/psf/black: 22.6.0 → 22.10.0](psf/black@22.6.0...22.10.0)
- https://github.com/myint/docformatterhttps://github.com/PyCQA/docformatter
- [github.com/PyCQA/docformatter: v1.3.1 → v1.5.0](PyCQA/docformatter@v1.3.1...v1.5.0)
- [github.com/PyCQA/flake8: 4.0.1 → 5.0.4](PyCQA/flake8@4.0.1...5.0.4)
- [github.com/executablebooks/mdformat: 0.7.14 → 0.7.16](executablebooks/mdformat@0.7.14...0.7.16)
- [github.com/executablebooks/mdformat: 0.7.14 → 0.7.16](executablebooks/mdformat@0.7.14...0.7.16)
- [github.com/codespell-project/codespell: v2.1.0 → v2.2.2](codespell-project/codespell@v2.1.0...v2.2.2)
- [github.com/pre-commit/mirrors-mypy: v0.961 → v0.990](pre-commit/mirrors-mypy@v0.961...v0.990)
@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Merging #28 (2baa837) into main (8a7338b) will decrease coverage by 0.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   79.56%   79.34%   -0.23%     
==========================================
  Files           4        4              
  Lines          93       92       -1     
==========================================
- Hits           74       73       -1     
  Misses         19       19              
Flag Coverage Δ
end_to_end 79.34% <100.00%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_cookie.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tobiasraabe tobiasraabe added this to the v1.3.0 milestone Nov 19, 2022
Copy link
Member

@tobiasraabe tobiasraabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! 👍

@tobiasraabe tobiasraabe merged commit d1fd493 into pytask-dev:main Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants