Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture warnings. #44

Merged
merged 7 commits into from
Aug 13, 2022
Merged

Capture warnings. #44

merged 7 commits into from
Aug 13, 2022

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented Aug 12, 2022

Fixes #41.

  • Requires a new release of pytask with published functions for capturing warnings. -> flexible imports.
  • Fix capturing of warnings in threads. Added note that capturing warnings is not thread-safe.

@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #44 (2cddd0e) into main (deba157) will decrease coverage by 0.76%.
The diff coverage is 90.66%.

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   96.84%   96.07%   -0.77%     
==========================================
  Files          13       13              
  Lines         412      459      +47     
==========================================
+ Hits          399      441      +42     
- Misses         13       18       +5     
Flag Coverage Δ
end_to_end 90.63% <86.66%> (-0.64%) ⬇️
integration 51.85% <45.33%> (+1.12%) ⬆️
unit 48.58% <20.00%> (-1.91%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pytask_parallel/execute.py 91.08% <88.13%> (-1.72%) ⬇️
tests/test_execute.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tobiasraabe tobiasraabe merged commit 9df24e8 into main Aug 13, 2022
@tobiasraabe tobiasraabe deleted the warnings branch August 13, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Add support for capturing warnings.
1 participant