Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better error message when node.state() throws error during DAG validation. #429

Merged
merged 1 commit into from Sep 29, 2023

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented Sep 29, 2023

No description provided.

@tobiasraabe tobiasraabe added this to the v0.4.0 milestone Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (132f515) 95.44% compared to head (a4be3be) 95.45%.

❗ Current head a4be3be differs from pull request most recent head 9d58501. Consider uploading reports for the commit 9d58501 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
+ Coverage   95.44%   95.45%   +0.01%     
==========================================
  Files          96       96              
  Lines        8478     8500      +22     
==========================================
+ Hits         8092     8114      +22     
  Misses        386      386              
Flag Coverage Δ
end_to_end 82.71% <30.43%> (-0.15%) ⬇️
integration 39.50% <17.39%> (-0.06%) ⬇️
unit 65.69% <100.00%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/_pytask/dag.py 100.00% <100.00%> (ø)
src/_pytask/traceback.py 97.91% <100.00%> (+0.18%) ⬆️
tests/test_dag.py 97.97% <100.00%> (+0.13%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobiasraabe tobiasraabe merged commit b65d3a6 into main Sep 29, 2023
15 checks passed
@tobiasraabe tobiasraabe deleted the better-error-message-hash branch September 29, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant