Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify removing internal tracebacks from exceptions with cause. #460

Merged
merged 2 commits into from Oct 23, 2023

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented Oct 23, 2023

No description provided.

@tobiasraabe tobiasraabe marked this pull request as ready for review October 23, 2023 10:11
@tobiasraabe tobiasraabe added this to the v0.4.2 milestone Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2c6855b) 65.28% compared to head (551ee56) 95.01%.
Report is 1 commits behind head on main.

❗ Current head 551ee56 differs from pull request most recent head 1ada1d0. Consider uploading reports for the commit 1ada1d0 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #460       +/-   ##
===========================================
+ Coverage   65.28%   95.01%   +29.73%     
===========================================
  Files          97       97               
  Lines        8549     8551        +2     
===========================================
+ Hits         5581     8125     +2544     
+ Misses       2968      426     -2542     
Flag Coverage Δ
end_to_end 82.42% <75.00%> (?)
integration 39.56% <12.50%> (-0.04%) ⬇️
unit 64.99% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/_pytask/collect.py 91.62% <100.00%> (+20.46%) ⬆️
src/_pytask/dag.py 100.00% <ø> (+21.35%) ⬆️
src/_pytask/execute.py 97.05% <ø> (+20.35%) ⬆️
src/_pytask/traceback.py 98.14% <100.00%> (+4.14%) ⬆️
tests/test_dag.py 98.16% <100.00%> (+54.23%) ⬆️
tests/test_execute.py 99.07% <ø> (+67.90%) ⬆️

... and 57 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobiasraabe tobiasraabe merged commit 4258297 into main Oct 23, 2023
18 checks passed
@tobiasraabe tobiasraabe deleted the simplify-removing-internal-tracebacks branch October 23, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant