Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checks for missing root nodes. #480

Merged
merged 5 commits into from Nov 7, 2023
Merged

Remove checks for missing root nodes. #480

merged 5 commits into from Nov 7, 2023

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented Nov 7, 2023

No description provided.

@tobiasraabe tobiasraabe added this to the v0.4.2 milestone Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2eb480e) 94.47% compared to head (20cb3c1) 94.43%.

❗ Current head 20cb3c1 differs from pull request most recent head b5687f2. Consider uploading reports for the commit b5687f2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #480      +/-   ##
==========================================
- Coverage   94.47%   94.43%   -0.04%     
==========================================
  Files         104      104              
  Lines        9065     9005      -60     
==========================================
- Hits         8564     8504      -60     
  Misses        501      501              
Flag Coverage Δ
end_to_end 81.19% <84.78%> (-0.03%) ⬇️
integration 39.86% <30.43%> (+0.09%) ⬆️
unit 66.58% <47.82%> (-0.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/_pytask/dag.py 100.00% <100.00%> (ø)
src/_pytask/dag_command.py 66.15% <100.00%> (-0.26%) ⬇️
src/_pytask/execute.py 97.32% <100.00%> (+0.04%) ⬆️
src/_pytask/hookspecs.py 100.00% <ø> (ø)
src/_pytask/session.py 93.93% <100.00%> (ø)
tests/test_dag.py 96.72% <100.00%> (-1.11%) ⬇️
tests/test_execute.py 99.22% <100.00%> (+0.06%) ⬆️
tests/test_skipping.py 100.00% <100.00%> (ø)
tests/test_tree_util.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobiasraabe tobiasraabe merged commit 7d20db2 into main Nov 7, 2023
20 checks passed
@tobiasraabe tobiasraabe deleted the remove-dag-check branch November 7, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant