Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip collection of MarkGenerator when using from pytask import mark. #576

Merged
merged 8 commits into from Mar 13, 2024

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented Mar 13, 2024

@tobiasraabe tobiasraabe changed the base branch from main to v0.4.x March 13, 2024 12:16
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.83%. Comparing base (c7f3da8) to head (996536a).

Additional details and impacted files
@@           Coverage Diff           @@
##           v0.4.x     #576   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files         106      106           
  Lines        8976     8980    +4     
=======================================
+ Hits         8782     8786    +4     
  Misses        194      194           
Flag Coverage Δ
end_to_end 82.69% <100.00%> (+<0.01%) ⬆️
integration 40.70% <25.00%> (-0.01%) ⬇️
unit 69.22% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobiasraabe
Copy link
Member Author

Hi @ChristianZimpelmann, can you install the version from this branch and telll me whether everything works fine using from pytask import mark?

pip install git+https://github.com/pytask-dev/pytask.git@fix-from-pytask-import-mark

@ChristianZimpelmann
Copy link
Contributor

It does. Thanks a lot!

@tobiasraabe
Copy link
Member Author

I will soon release v0.4.6.

@tobiasraabe tobiasraabe merged commit 19325a1 into v0.4.x Mar 13, 2024
25 checks passed
@tobiasraabe tobiasraabe deleted the fix-from-pytask-import-mark branch March 13, 2024 15:22
@tobiasraabe tobiasraabe added this to the v0.4.6 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants