split tests #35
Merged
split tests #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpk42
reviewed
Nov 16, 2016
| @@ -35,3 +33,6 @@ minversion=2.0 | |||
| addopts= -rxsX | |||
| pep8ignore = E501 E128 E127 | |||
There was a problem hiding this comment.
are the errors listed here still ignored with the new invocation?
In principle a large refactoring/code-shifting PR should try to avoid also changing semantics ...
There was a problem hiding this comment.
those errors disappeared with the changes, i removed the setting since its no longer needed
|
sure, i understand that you "fixed" the pep8 issues. I once put them there by intention because i didn't want to adhere to all. anyway, not going to argue this further but reserve the liberty to re-add ignores later. please rebase/squatch the commits and merge the PR. |
RonnyPfannschmidt
force-pushed
the
test-argument-introduction
branch
from
455fb5a
to
a9d3fda
Compare
* extends tox and travis config to more python versions * lines up closer with pep8
RonnyPfannschmidt
force-pushed
the
test-argument-introduction
branch
from
a9d3fda
to
fb44448
Compare
|
@RonnyPfannschmidt slick man! This looks great :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #32