New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure the type hints support the writer unsetting in tagtracer #423

Merged

bluetech merged 1 commit into pytest-dev:main from hoefling:typing/support-unsetting-writer-in-tagtracer

Jul 20, 2023

Member

hoefling commented Jul 20, 2023

Reason: pytest uses TagTracer.setwriter(None) when unsetting the tracer in https://github.com/pytest-dev/pytest/blob/1de0923e83e3258709559d86d142adaab65a42d8/src/_pytest/helpconfig.py#L126. This PR adjusts the typing of TagTracer.setwriter to support this case.


          ensure the type hints support the writer unsetting in tagtracer

ad2f915

Signed-off-by: Oleg Hoefling <oleg.hoefling@ionos.com>

hoefling mentioned this pull request

Add stubs for pluggy==1.2.0 python/typeshed#10473

Merged

bluetech approved these changes

View reviewed changes

Member

bluetech left a comment

Thanks

bluetech merged commit 3820b49 into pytest-dev:main

18 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment