Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More steps towards exporting our typings #430

Merged
merged 7 commits into from
Aug 26, 2023
Merged

Conversation

bluetech
Copy link
Member

See #428. I believe this handles all of the remaining items.

After this PR, I'll send a final PR which exports the typings and adds a changelog with all of the changes.

…pts`

We already have established types `HookimplMarker`, `HookspecMarker` so
we should be consistent with the casing.

The types haven't been public in a released version yet so OK to change.
The return value of the `pm.parse_hook{spec,impl}_opts` see need to
document them.
Used in hook monitoring and in `pm.hook.my_hook.get_hookimpls()`.

Refs pytest-dev#428.
Catch broken references.
@bluetech
Copy link
Member Author

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bluetech bluetech merged commit 1b1042e into pytest-dev:main Aug 26, 2023
16 of 17 checks passed
@bluetech bluetech deleted the typing3 branch August 26, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants