Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to weed out "Framework :: Pytest" false-positives #53

Closed
nicoddemus opened this issue Jul 3, 2020 · 3 comments
Closed

Try to weed out "Framework :: Pytest" false-positives #53

nicoddemus opened this issue Jul 3, 2020 · 3 comments

Comments

@nicoddemus
Copy link
Member

It seems a lot of packages are using the Framework :: Pytest classifier even though they are not plugins, but only use pytest to test their own code. This generates a bunch of false positives that we should avoid showing.

@The-Compiler
Copy link
Member

I've been thinking about this recently as well - but I'm not sure what we can do, other than a hand-written list of exceptions?

FWIW I've tried to track down some of the repos and submit a PR, but many of those don't seem to exist, so I only ended up with https://github.com/BotEX-Developers/botbase/pull/12.

@nicoddemus
Copy link
Member Author

Yeah I'm not sure either, but a thought that occurred was:

For all packages that don't start with "pytest-" and declare Framework :: Pytest, look at the source tarball for sign of entry points (hand parsing setup.py, setup.cfg, etc).

Of course there are obvious drawbacks: false positives, manual parsing is tricky/might be flaky, etc., but in the end we might get better results than what we are having currently.

nicoddemus added a commit to nicoddemus/plugincompat that referenced this issue Aug 22, 2020
The number of false positivies is too large, only list pytest-* plugins
for now until a final solution to pytest-dev#53 is implemented.
gotcha added a commit to gotcha/plugincompat that referenced this issue Mar 31, 2021
@nicoddemus
Copy link
Member Author

Closed by #66.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants