Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for glob.glob recursive flag #116

Closed
matteosimone opened this issue Jul 21, 2016 · 2 comments
Closed

Add support for glob.glob recursive flag #116

matteosimone opened this issue Jul 21, 2016 · 2 comments
Assignees
@mrbean-bremen
Labels
enhancement

Comments

@matteosimone
Copy link

python3.5 added support for a recursive flag for glob.glob. It would be great if this was supported by this library.
mrbean-bremen added a commit to mrbean-bremen/pyfakefs that referenced this issue Jul 26, 2016
@mrbean-bremen
Removed glob from fake modules
a5da476 
- glob/iglob shall work out of the box if faking os/os.path
- shall fix pytest-dev#59 and pytest-dev#116
@mrbean-bremen
Copy link
Member

IMHO, faking glob is not needed at all (see my comment in issue #59).
I created a branch where glob is not faked out (https://github.com/mrbean-bremen/pyfakefs/tree/no_fake_glob) - if you want, you can check it out and play around, it should fix the issue.

mrbean-bremen added a commit to mrbean-bremen/pyfakefs that referenced this issue Oct 2, 2016
@mrbean-bremen
Added support for glob.iglob and recursive flag
e795c65 
- use sources from Python 3.5, slightly adapted to work under Python 2
and use fake file system
- fixes pytest-dev#59 and pytest-dev#116
@mrbean-bremen mrbean-bremen mentioned this issue Oct 2, 2016
Merged
@mrbean-bremen mrbean-bremen self-assigned this Oct 2, 2016
@mrbean-bremen
Copy link
Member

Fixed via #124.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrbean-bremen mrbean-bremen

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matteosimone @mrbean-bremen