Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI tests failing for Python 3.8 #504

Closed
7 tasks done
mrbean-bremen opened this issue Nov 16, 2019 · 1 comment
Closed
7 tasks done

CI tests failing for Python 3.8 #504

mrbean-bremen opened this issue Nov 16, 2019 · 1 comment
Labels
bug

Comments

@mrbean-bremen
Copy link
Member

mrbean-bremen commented Nov 16, 2019 •
edited

Adding Python 3.8 to the CI tests shows several failing unit tests:

  • in the linux tests, several of the shutil tests are failing
  • under MacOS, 2 of the pytest tests fail
  • in Windows, both shutil tests and several real OS tests fail

To be fixed:

  • shutil: os.sendfile not implemented (linux only)
  • shutil: DirEntry cannot be converted to PathLike (linux/windows)
  • shutil: missing Windows specific attributes in os.stat_result (windows)
  • devnull is now supported (windows only)
  • test_add_existing_real_directory_symlink fails (windows only)
  • UNC local paths may be returned by os.readlink (windows)
  • shutil: _fastcopy_fcopyfile uses system calls (macos only)
mrbean-bremen added a commit that referenced this issue Nov 17, 2019
@mrbean-bremen
Fixed some failing tests under Windows with Python 3.8
8fa0675 
- added support for devnull in Windows / Python 3.8
- added preliminary support for st_file_attributes and st_reparse_tag
  (Windows-specific os.stat_result attributes)
- consider local UNC path returned by os.readlink in tests
- see #504
mrbean-bremen added a commit to mrbean-bremen/pyfakefs that referenced this issue Nov 18, 2019
@mrbean-bremen
Added sendfile implementation (posix only)
480bfc3 
- see pytest-dev#504
mrbean-bremen added a commit to mrbean-bremen/pyfakefs that referenced this issue Nov 18, 2019
@mrbean-bremen
Added sendfile implementation (posix only)
7b9c03b 
- see pytest-dev#504
mrbean-bremen added a commit that referenced this issue Nov 18, 2019
@mrbean-bremen
Always implement os.PathLike for DirEntry in Python >= 3.6
6bffb65 
- added CI tests for Python 3.8 (Linux and Windows)
- skip failing Windows test temporarily for Python 3.8
  (test_add_existing_real_directory_symlink)
- see #504
mrbean-bremen added a commit to mrbean-bremen/pyfakefs that referenced this issue Nov 21, 2019
@mrbean-bremen
Added special handling for patching shutil under MacOs under Python 3.8
5fe5c1b 
- set shutil attribute to False that allows using native
  posix copy function during patching
- see pytest-dev#504
mrbean-bremen added a commit to mrbean-bremen/pyfakefs that referenced this issue Nov 22, 2019
@mrbean-bremen
Added support for UNC prefix in links under Windows
4c65784 
- do not allow sendfile() to regular files under MacOs
- added note about last version supporting Python 2.7 and 3.4
- see pytest-dev#504
@mrbean-bremen
Copy link
Member Author

All tests passing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mrbean-bremen