Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate test suite execution #1010

Merged

Conversation

kurtmckee
Copy link
Contributor

Describe the changes

This PR improves the isolation of filesystem interactions when the test suite is executing. Its purpose is to allow multiple Python interpreters to execute the test suite in parallel (tox run-parallel).

  • Unique temporary directories are now used for symlink tests.

    (Previous behavior was to use the pytest/tests/fixtures/ directory.)

  • Using a unique temporary directory when calling create_real_paths().

    (Previous behavior was to append "root" to the end of the OS temp directory path.)

Tasks

  • Unit tests added that reproduce the issue or prove feature is working
  • Fix or feature added
  • Entry to release notes added
  • Pre-commit CI shows no errors
  • Unit tests passing
  • For documentation changes: The Read the Docs preview builds and looks as expected

Fixes #1009

Copy link
Member

@mrbean-bremen mrbean-bremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks - also for catching the potential symlink leak!

@mrbean-bremen mrbean-bremen merged commit d11b848 into pytest-dev:main May 2, 2024
64 checks passed
@kurtmckee kurtmckee deleted the isolate-symlinks-issue-1009 branch May 2, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileExistsError raised when running test suite in parallel
2 participants