New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support to fake out the backported scandir #333

Merged

mrbean-bremen merged 2 commits into pytest-dev:master from mrbean-bremen:patcher

Dec 13, 2017

Member

mrbean-bremen commented Dec 9, 2017 •

edited

refactored Patcher for easier possibility to add new modules
moved fake scandir implementation into separate module and use it both for os.scandir and scandir.scandir
shall fix Pyfakefs doesn't work with Python 2.6+ backport of os.scandir #332


          Refactored Patcher to be more generic

7cdf13b

Member Author

mrbean-bremen commented Dec 9, 2017

A few notes:

I did not add a generic mechanism to add a new module to Patcher, but doing this should be easy now
the tests for scandir.scandir() are only running if scandir is installed - I didn't do this in the Travis build, only tested it locally
this PR will clash with the other PR, so one of them will have to be rebased


          Added support for patching scandir module

2343f44

- module contains backported os.scandir

mrbean-bremen force-pushed the patcher branch from e8d235f to 2343f44 Compare

December 10, 2017 20:40

mrbean-bremen merged commit 6c685a4 into pytest-dev:master

mrbean-bremen deleted the patcher branch

January 3, 2018 18:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment