Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add attribute access for some moved constants back to fake_filesystem #811

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Add attribute access for some moved constants back to fake_filesystem #811

merged 1 commit into from
Apr 13, 2023

Conversation

mrbean-bremen
Copy link
Member

@mrbean-bremen mrbean-bremen commented Apr 12, 2023 •
edited
Loading

This still leaves USER_ID and GROUP_ID as not accessible from fake_filesystem, as discussed in the issue.

Tasks

  • Unit tests added that reproduce the issue or prove feature is working
  • Fix or feature added
  • Entry to release notes added
  • Pre-commit CI shows no errors
  • Unit tests passing
  • For documentation changes: The Read the Docs preview builds and looks as expected

@mrbean-bremen
Add attribute access for some moved constants back to fake_filesystem
ceebab7 
- some if these had been accessed in user code,
  which caused a regression
- add convenience function get_uid()/get_gid()
- see pytest-dev#809
@mrbean-bremen mrbean-bremen merged commit ff60173 into pytest-dev:main Apr 13, 2023
@mrbean-bremen mrbean-bremen deleted the missing-attributes branch August 17, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mrbean-bremen