add support for async contextvars #153
Conversation
|
works on python 3.8 at least 😅 |
|
Why are the hypothesis tests removed? |
oops |
honestly its because my internet went down last night and I couldn't install the hypothesis package at the time |
|
one caveat I might mention about this implementation is that EVERY async task will run in the same context. normally child tasks would inherit a COPY of the parent task's context. but it's probably an acceptable trade off in a test environment. but it could cause context to unexpectedly leak from a child task into a parent task. it's fixable by making the root task a special case that gets the original context while child tasks get copies. but not necessary for my use case ;) |
|
I opened https://bugs.python.org/issue40320 to officially request the ability to pass context to task |
|
I just hit a similar problem regarding contextvars with async-yield fixtures. |
* All test cases in tests/test_cli_proxy.py are marked "xfail" because there is an upstream issue rendering those tests always failing while real-world use cases have no problems. - ref) pytest-dev/pytest-asyncio#153
* feat: Add background task support
* feat: Implement progress bar for rescanning images using bgtask API
* refactor: Clean up BaseFunction inheritance using contextvars
- Previously, to bind the current session with API function classes,
we generated new type objects at runtime.
- This has confused IDEs and type checkers.
- Now type checkers can statically deduce the types for individual API
function classes.
- Now we use contextvars (ai.backend.client.session.api_session)
to keep the reference to the current session.
- There are *NO* public Session/AsyncSession API changes!
- Only the API function classes need to be rewritten.
- For synchronous Session, we pass the context to the separate worker
thread using copy_context() whenever calling API functions, which is
a light-weight operation.
* fix: Remove redundant src/ai/backend/client/etcd.py which had been already
copied to src/ai/backend/client/func/etcd.py
* ci: Bump the lint Python version to 3.7
* ci: Remove Python 3.6 from AppVeyor
* ci: Make Python 3.8 as the officially supported environment by removing it
from "allow_failures" environments in Travis CI
* ci: Now type errors are no longer ignored, and all remaining type errors are
now fixed.
* test: All test cases in tests/cli/test_cli_proxy.py are marked "xfail"
because there is an upstream issue rendering those tests always
failing while real-world use cases have no problems.
- ref) pytest-dev/pytest-asyncio#153
BREAKING-CHANGE: Dropped Python 3.6 support. Now it requires Python 3.7 or higher.
It should. I use them in my app tests which is the reason I did this. |
|
Works great! Contextvars are such a neat feature ... Just had to do a minor rebase the branche because master changed from doing "append if not in item.fixturenames" with "remove if in item.fixturenames then insert". Thank you very much! 🎩 |
|
Verified that this one works. I like this one more than #161 since I can easily copy the necessary parts to my |
|
Is this fix abandoned? |
|
I really hate to do this, but I'm closing this PR in favour of the solution proposed in #312. I'll my best to outline my reasons. I like that you found a nice Task abstraction. It has a high "code locality" (i.e. the functionality coherent and found mostly inside However, the The PR also introduces the Python 3.11 introduces asyncio.Runner, which essentially allows running multiple async functions in the same context. #312 introduces the concept of a Runner in pytest-asyncio. I think this is the approach we should take Others have reported they could use similar code in their conftest.py, so this may serve them as a workaround, until #127 is fixed. I'm sorry this PR was stale for such a long time. A single maintainer can only spend so much time and we only "added staff" in the beginning of this year. |
this ugly hack causes the context to be preserved across all excursions into async land. this fixes #127