Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes pytest-dev/pytest-asyncio#219 #221

Merged
merged 3 commits into from
Jan 11, 2022
Merged

Fixes pytest-dev/pytest-asyncio#219 #221

merged 3 commits into from
Jan 11, 2022

Conversation

kriek
Copy link
Contributor

@kriek kriek commented Jul 16, 2021 •
edited

Fixes #219

@kriek kriek mentioned this pull request Jul 16, 2021
Closed
@WhyNotHugo
Copy link

Add "#219" to the PR description to link it to that issue.

@wjsi wjsi mentioned this pull request Dec 21, 2021
Closed
@asvetlov
Copy link
Contributor

asvetlov commented Jan 6, 2022

Any chance to write a test?
Perhaps the test doesn't need Ctrl+C, an exception raised from setup part of the fixture should be enough.

@asvetlov
Copy link
Contributor

The proposed test idea doesn't work, let's merge it as-is.

@asvetlov asvetlov merged commit 775da95 into pytest-dev:master Jan 11, 2022
@kriek
Copy link
Contributor Author

kriek commented Jan 12, 2022

Thanks for merging, I was not able to write a test either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@seifertm seifertm Awaiting requested review from seifertm

@Tinche Tinche Awaiting requested review from Tinche

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KeyboardInterrupt during async generator fixture setup results in RuntimeError
3 participants
@kriek @WhyNotHugo @asvetlov