-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve output with invalid asyncio_mode #557
Conversation
The Python 3.12 failure is unrelated:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! This definitely makes sense.
Could you also add an entry to docs/source/reference/changelog.rst
? The new version can just be 0.22.0 (UNRELEASED)
I adjusted the warnings filters so that the DeprecationWarnings on Python 3.12 are ignored. The CI should be green as soon as you rebase your branch. |
b02ffa0
to
3841edf
Compare
Improved and rebased! |
Instead of a long INTERNALERROR> stack trace, output a proper error message: $ pytest -o asyncio_mode=True =================== test session starts ==================== platform linux -- Python 3.11.3, pytest-7.3.1, pluggy-1.0.0 ERROR: 'True' is not a valid asyncio_mode. Valid modes: auto, strict. See pytest-dev/pytest#11083
3841edf
to
26d10be
Compare
Great, thank you for the quick turnaround! |
Instead of a long INTERNALERROR> stack trace, output a proper error
message:
See pytest-dev/pytest#11083