Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lowest required pytest version #260

Merged

Conversation

sliwinski-milosz
Copy link
Contributor

We use bool type ini option for bdd_strict_gherkin.

Support for that type has been added to Parser.addini starting from pytest==2.9.0.
https://docs.pytest.org/en/latest/changelog.html#id625

Due to above pytest==2.9.0 is the lowest version that latest pytest-bdd can work with.

For testing with pytest==2.9.0 you have to use pytest-xdist<=1.17 as newer pytest-xdist requires pytest>=3.0.0.

@coveralls
Copy link

coveralls commented Oct 25, 2018

Coverage Status

Coverage remained the same at 93.363% when pulling 30eb6a5 on sliwinski-milosz:update_lowest_required_pytest into 9dd326a on pytest-dev:master.

Copy link
Contributor

@youtux youtux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I think we don't need a major version bump, since the compatibility with pytest<2.9.0 has been broken in pytest-bdd 3.0.0.
Can you also bump the version to of pytest-bdd to 3.0.1 and add an entry in the changelog?

@youtux youtux merged commit f7a30fc into pytest-dev:master Nov 1, 2018
@youtux
Copy link
Contributor

youtux commented Nov 1, 2018

Thank you again @sliwinski-milosz :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants