Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gherkin terminal reporter tests steps renamed to not being collected … #292

Merged
merged 2 commits into from
Jul 4, 2019

Conversation

sliwinski-milosz
Copy link
Contributor

@sliwinski-milosz sliwinski-milosz commented Feb 23, 2019

…as test items by pytest

Pytest runs functions as test when they start with test*. Due to that some our test steps are treated as tests and pytest runs them:

tests/feature/test_gherkin_terminal_reporter.py::tests_are_run PASSED                                         [ 26%]
tests/feature/test_gherkin_terminal_reporter.py::tests_are_run_with_verbose_mode PASSED                       [ 27%]
tests/feature/test_gherkin_terminal_reporter.py::tests_are_run_with_very_verbose_mode PASSED                  [ 28%]
tests/feature/test_gherkin_terminal_reporter.py::tests_are_run_with_step_expanded_mode PASSED                 [ 28%]
tests/feature/test_gherkin_terminal_reporter.py::tests_are_run_with_any_verbosity_mode[compact mode] PASSED   [ 29%]
tests/feature/test_gherkin_terminal_reporter.py::tests_are_run_with_any_verbosity_mode[line per test] PASSED  [ 30%]
tests/feature/test_gherkin_terminal_reporter.py::tests_are_run_with_any_verbosity_mode[verbose] PASSED        [ 30%]
tests/feature/test_gherkin_terminal_reporter.py::tests_are_run_with___showlocals PASSED                       [ 31%]

This PR renames those steps.

@coveralls
Copy link

coveralls commented Feb 23, 2019

Coverage Status

Coverage remained the same at 93.545% when pulling 7386069 on sliwinski-milosz:rename_tests into a8795da on pytest-dev:master.

@youtux
Copy link
Contributor

youtux commented Apr 14, 2019

This seems more like a bug of pytest-bdd that we should fix properly. Do you feel like digging into that? Otherwise we can just create an issue to track it.

@sliwinski-milosz
Copy link
Contributor Author

I reported new issue to track it. Can we merge this PR? :)

@youtux youtux merged commit b3370c3 into pytest-dev:master Jul 4, 2019
@youtux
Copy link
Contributor

youtux commented Jul 4, 2019

I'm sorry that it took me so long

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants